Skip to content

Infrastructure Stream — Task Plan (post-implementation)

Compares the planned tasks (see ../task-plan.md) against what shipped in infrastructure PR #451 and the PR #452 follow-up.

All planned tasks landed. A handful of in-scope cleanups were folded in because the diff already touched the affected code paths:

AreaPlanRealityIn scope?
PARTITION_VAULT_MAP[prod]UnchangedCorrected SystemsOAMProdOAMIn scope: this PR introduces the first new prod-vault reads, so the mismatch became material.
Inline-BuildSpec drift checkAdd per-partition check at deploy loop startShipped; also treats None and null outputs as empty to avoid false positives.In scope: the check itself was the planned deliverable; the null-output handling was a same-edit fix.
AMAZON_CREATORS_API_JSON lifetimeImplicitExplicit unset at the start of each partition iterationIn scope: cleanly required for multi-partition all invocations.
SSO-login orderingNot specifiedMoved before drift-check AWS callsIn scope: drift check would otherwise silently skip on expired SSO.
GitHub Actions log maskingNot specified::add-mask:: registered for all credential fieldsIn scope: PR introduces the first paths that handle credential values from 1Password in CI.

Not in the original task-plan; surfaced during the prod rollout and tracked as PDEV-452.

  • The original task-plan’s “explicit --region everywhere” intent was set up by adding AMPLIFY_REGION_OVERRIDES, but the partition-loop code paths that followed (drift check, env-var update, compute-role attach) inherited the AWS CLI default region instead of consuming the override. PR #452 closes that gap by resolving a per-partition amplify_region at the top of the loop and passing it via --region at every call site, with no conditional branching.
  • npm run lint, npm run build, npm test: all green on both PRs.
  • bash -n amm.sh + shellcheck amm.sh: clean (two pre-existing SC2016 infos on single-quoted jq filters are unrelated and intentional).
  • Local end-to-end: amm.sh Alpha002 dev runs cleanly on PR #451 head, populates all four AMAZON_* env vars on dev-arda-frontend-app, and is idempotent on re-run.
  • Production end-to-end (post-PR #452): amm.sh Alpha001 prod runs cleanly, the drift check correctly targets us-east-2 for the prod Amplify app duhexavnwh88g, and the four env vars land on the prod app.